Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to onStartupFinished #343

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Conversation

jasonwilliams
Copy link
Contributor

@jasonwilliams jasonwilliams commented Oct 27, 2020

from 1.46 onwards onStartupFinished can be used instead of *
https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_46.md#onstartupfinished-activation-event
https://code.visualstudio.com/api/references/activation-events#onStartupFinished

To ensure a great end user experience, please use * activation event in your extension only when no other activation events combination works in your use-case. onStartupFinished is similar to the * activation event, but it will not slow down VS Code startup.

This change can help with VSCode startup time.

from 1.46 onwards `onStartupFinished` can be used instead of `*`
https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_46.md#onstartupfinished-activation-event
https://code.visualstudio.com/api/references/activation-events#onStartupFinished

_To ensure a great end user experience, please use `*` activation event in your extension only when no other activation events combination works in your use-case._

This change can help with VSCode startup time.
@alefragnani
Copy link
Owner

Hi @jasonwilliams ,

I've noticed that announcement back then, and was planning to give it a try. Thank you for making it happen earlier 😄 .

It should be available on the next release.

Thank you

@alefragnani alefragnani self-assigned this Oct 28, 2020
@alefragnani alefragnani added internal vscode api adoption Adopting new/updated VS Code APIs labels Oct 28, 2020
@alefragnani alefragnani added this to the 11.5.0 milestone Oct 28, 2020
@alefragnani alefragnani merged commit a2548da into alefragnani:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal vscode api adoption Adopting new/updated VS Code APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants