Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations #367

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Update translations #367

merged 3 commits into from
Jan 15, 2021

Conversation

loniceras
Copy link
Contributor

Hi. Some new translations have been made in this PR.

Copy link
Owner

@alefragnani alefragnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some comments. Basically to replace the n named ids, to use something more meaningful.

package.json Outdated
"visibility": "collapsed"
}
]
},
"viewsWelcome": [
{
"view": "bookmarksExplorer",
"contents": "In order to use Bookmarks, you have to open a folder or workspace first.\n[Open a Folder](command:_bookmarks.openFolderWelcome)\n[Open a Workspace](command:workbench.action.openWorkspace)\nTo learn more about how to use Bookmarks in VS Code [read the docs](http://github.com/alefragnani/vscode-bookmarks/#bookmarks).",
"contents": "%bookmarks.viewsWelcome.bookmarksExplorer.contents.1%",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using n on ids. Use something meaningful, maybe based on the when clause, like contents.whenEmpty

package.json Outdated
"when": "workbenchState == empty"
},
{
"view": "bookmarksExplorer",
"contents": "No bookmarks yet.\nIn order to use Bookmarks, you have to open a file in the editor.\n[Open a File](command:workbench.action.quickOpen)\nTo learn more about how to use Bookmarks in VS Code [read the docs](http://github.com/alefragnani/vscode-bookmarks/#bookmarks).",
"contents": "%bookmarks.viewsWelcome.bookmarksExplorer.contents.2%",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using n on ids. Use something meaningful, maybe based on the when clause, like contents.whenNoFileOpen

package.json Outdated
"when": "workbenchState != empty && !editorIsOpen"
},
{
"view": "bookmarksExplorer",
"contents": "No bookmarks yet.\nIn order to use Bookmarks, place the cursor in any location in the file and run the command:\n[Bookmarks: Toggle](command:bookmarks.toggle)\nTo learn more about how to use Bookmarks in VS Code [read the docs](http://github.com/alefragnani/vscode-bookmarks/#bookmarks).",
"contents": "%bookmarks.viewsWelcome.bookmarksExplorer.contents.3%",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using n on ids. Use something meaningful, maybe based on the when clause, like contents.whenHasFileOpen

package.json Outdated
"when": "workbenchState != empty && editorIsOpen"
}
],
"commands": [
{
"command": "bookmarks.toggle",
"title": "%bookmarks.commands.toggle.title%",
"category": "Bookmarks"
"category": "%bookmarks.commands.category.1%"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using n on ids. Use %bookmarks.commands.category.bookmarks% instead.

package.json Outdated
},
{
"command": "bookmarks.jumpToNext",
"title": "%bookmarks.commands.jumpToNext.title%",
"category": "Bookmarks"
"category": "%bookmarks.commands.category.1%"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using n on ids. Use %bookmarks.commands.category.bookmarks% instead

Comment on lines 48 to 51
"bookmarks.configuration.label.suggestion.enumDescriptions.1": "Don't use the selection (original behavior)",
"bookmarks.configuration.label.suggestion.enumDescriptions.2": "Use the selected text (if available) directly, no confirmation required",
"bookmarks.configuration.label.suggestion.enumDescriptions.3": "Suggests the selected text (if available). You still need to confirm.",
"bookmarks.configuration.label.suggestion.enumDescriptions.4": "Suggests the selected text (if available) or the entire line (when has no selection). You still need to confirm.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the n ids to the new ids

Comment on lines 5 to 7
"bookmarks.viewsWelcome.bookmarksExplorer.contents.1": "为了使用书签,你需要打开一个文件夹或工作区。\n[打开文件夹](command:_bookmarks.openFolderWelcome)\n[打开工作区](command:workbench.action.openWorkspace)\n可以[阅读文档](http://github.com/alefragnani/vscode-bookmarks/#bookmarks)了解关于 VS Code 中使用书签的更多信息。",
"bookmarks.viewsWelcome.bookmarksExplorer.contents.2": "目前无书签。\n为了使用书签,你需要在编辑器中打开一个文件。\n[打开文件](command:workbench.action.quickOpen)\n可以[阅读文档](http://github.com/alefragnani/vscode-bookmarks/#bookmarks)了解关于 VS Code 中使用书签的更多信息。",
"bookmarks.viewsWelcome.bookmarksExplorer.contents.3": "目前无书签。\n为了使用书签,你需要将光标放在文件的任意位置,然后运行命令:\n[书签: 开关](command:bookmarks.toggle)\n可以[阅读文档](http://github.com/alefragnani/vscode-bookmarks/#bookmarks)了解关于 VS Code 中使用书签的更多信息。",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the n ids to the new ids

Comment on lines 10 to 11
"bookmarks.commands.category.1": "书签",
"bookmarks.commands.category.2": "书签(选择)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the n ids to the new ids

Comment on lines 45 to 46
"bookmarks.configuration.multicursor.toggleMode.enumDescriptions.1": "如果至少有一行没有书签,则在所有选中的行创建书签。",
"bookmarks.configuration.multicursor.toggleMode.enumDescriptions.2": "分别开关每一个选中的行的书签。",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the n ids to the new ids

Comment on lines 48 to 51
"bookmarks.configuration.label.suggestion.enumDescriptions.1": "无建议的标签,需要手动输入标签。",
"bookmarks.configuration.label.suggestion.enumDescriptions.2": "使用选择的文本作为标签,不需要额外的确认。",
"bookmarks.configuration.label.suggestion.enumDescriptions.3": "使用选择的文本作为标签,需要额外的确认。",
"bookmarks.configuration.label.suggestion.enumDescriptions.4": "使用选择的文本或(无选择的文本时)使用整个行作为标签,需要额外的确认。",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the n ids to the new ids

@alefragnani
Copy link
Owner

Hi @loniceras ,

First of all, thank your for your PR 👍

I've made some comments. Basically because of some of the ids are using a n based pattern. Please, update to something more meaningful, for easier understanding.

Thank you

@alefragnani alefragnani self-assigned this Jan 7, 2021
@alefragnani alefragnani added documentation PR needs update The PR needs review by the author labels Jan 7, 2021
@alefragnani alefragnani added this to the January 2021 milestone Jan 7, 2021
@loniceras
Copy link
Contributor Author

Hi! Thank you for your detailed comments. I'v made a revision based on these suggestions :)

@alefragnani
Copy link
Owner

Thank you for the updates.

Everything appears to be ok. I’m planning to test it this weekend, and should be available in the next release.

Thank you

@alefragnani alefragnani added PR needs test PR tested and removed PR needs update The PR needs review by the author PR needs test labels Jan 8, 2021
@alefragnani alefragnani merged commit d55e730 into alefragnani:master Jan 15, 2021
alefragnani added a commit that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants