react-native-router-flux@3.39.0 breaks build 🚨 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
react-native-router-flux just published its new version 3.39.0.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As react-native-router-flux is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 89 commits .
2147a32fix rn 0.43 comp (#1819)6c52665bump version0a4c400Add selection view to show below navigationBarTitleImage (#1756)30e8959Maintain tab parentIndex when jumping tabs (#1775)4b57417Merge branch 'master' of https://github.com/aksonov/react-native-router-flux7f181d1disable Example tests because of new jest issuescbef99fadd 'fade' to direction type (#1705)1382d3cupdate documentation for nested routing (#1742)897c41bupdate demo to work with latest React Native6cb358bfixed issue #1688 (in accordance with BREAKING: Android - ReactNativeHost getUseDeveloperSupport to public facebook/react-native#11329) (#1691)9dcef8ause lodash's isEqual for property comparison (#1682)bdc39daadded icon to SceneProps type (#1546)cacd757Adding sizes NavBar for Windows (#1548)473ee18Added backAndroidHandler to routerProps typings (#1586)1e7f4fcaddtabBarBackgroundImageStyleprop (#1611)There are 89 commits in total. See the full diff.