Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: forget_vm called twice when VM init times out #138

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fix: forget_vm called twice when VM init times out #138

merged 1 commit into from
Feb 16, 2022

Conversation

hoh
Copy link
Member

@hoh hoh commented Feb 10, 2022

Solution: Allow execution to be already missing.

See Sentry error https://sentry.io/organizations/alephim/issues/3001246903/?project=6193637&query=is%3Aunresolved

@hoh hoh added the bug Something isn't working label Feb 10, 2022
@hoh hoh requested a review from odesenfans February 10, 2022 16:00
odesenfans
odesenfans reviewed Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick.

vm_supervisor/pool.py Outdated Show resolved Hide resolved
@hoh
Fix: forget_vm called twice when VM init times out
8659a8a 
Solution: Allow execution to be already missing.
@hoh hoh merged commit 2b373ce into main Feb 16, 2022
@hoh hoh deleted the hoh-fix-pop branch February 16, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoh @odesenfans