Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: VM resource seconds field was ignored #144

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fix: VM resource seconds field was ignored #144

merged 1 commit into from
Feb 16, 2022

Conversation

hoh
Copy link
Member

@hoh hoh commented Feb 14, 2022

Solution: Timeout the request after the number of seconds has passed.

Fixes #139

@hoh
Fix: VM resource seconds field was ignored
521e792 
Solution: Timeout the request after the number of seconds has passed.

Fixes #139
@hoh hoh added the enhancement New feature or request label Feb 14, 2022
@hoh hoh requested a review from odesenfans February 14, 2022 15:11
odesenfans
odesenfans approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright 👍

@hoh hoh merged commit eb2de3f into main Feb 16, 2022
@hoh hoh deleted the hoh-vm-duration branch February 16, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use VM timeout as the lowest between settings and VM duration
2 participants
@hoh @odesenfans