Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Database access during benchmarks errored #173

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Fix: Database access during benchmarks errored #173

merged 1 commit into from
Apr 28, 2022

Conversation

hoh
Copy link
Member

@hoh hoh commented Apr 26, 2022 •
edited
Loading

Solution: Initiate the database in the benchmark procedure.

An alternative would be to make the database optional and ignore it in benchmarks.

@hoh
Fix: Database access during benchmarks errored
5f31bcd 
Solution: Initiate the database in the benchmark procedure.
@hoh hoh added the bug Something isn't working label Apr 26, 2022
@hoh hoh requested a review from odesenfans April 26, 2022 17:49
odesenfans
odesenfans approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me. I think it's better to run the benchmarks with the DB so that we stay close to the behavior in production.

@hoh hoh merged commit 9163c13 into main Apr 28, 2022
@hoh hoh deleted the hoh-fix-metrics-benchmark branch May 11, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoh @odesenfans