Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Recording VM usage crashed if process had stopped beforehand #198

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix: Recording VM usage crashed if process had stopped beforehand #198

merged 1 commit into from
Jun 28, 2022

Conversation

hoh
Copy link
Member

@hoh hoh commented Jun 22, 2022 •
edited
Loading

Not the cleanest code due to duplication, but the most simple I could think of.

@hoh hoh added the bug Something isn't working label Jun 22, 2022
@hoh hoh requested a review from odesenfans June 22, 2022 17:43
odesenfans
odesenfans approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Technically you could split the definition of the execution record and do await save_record(record) at the end but that's not a big issue.

vm_supervisor/models.py Outdated Show resolved Hide resolved
vm_supervisor/vm/firecracker_microvm.py Outdated Show resolved Hide resolved
@hoh hoh force-pushed the hoh-fix-process-missing branch from 9d14bf2 to 70f6912 Compare June 28, 2022 09:23
@hoh hoh force-pushed the hoh-fix-process-missing branch from 70f6912 to 8558410 Compare June 28, 2022 09:23
@hoh hoh merged commit 0800280 into main Jun 28, 2022
@hoh hoh deleted the hoh-fix-process-missing branch June 28, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoh @odesenfans