Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CDN link from the status page #465

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Remove CDN link from the status page #465

merged 3 commits into from
Nov 20, 2023

Conversation

BjrInt
Copy link
Member

@BjrInt BjrInt commented Nov 14, 2023

The status page is using a CDN to get the content of the chart library, this PR ships it as a static file inside of the repo

To do before merging ⚠️

This library is licensed as APACHE v2, a copy of the license should be included somewhere in the source.

@hoh
Copy link
Member

hoh commented Nov 15, 2023

We should add a license page with the Apache Licence, or add it to the bottom of the page hidden.

Suggestion:

<details>
                    <summary>License(s): The Licence</summary>
                    <pre style="word-wrap: break-word; white-space: pre-wrap;">The License ...
                    </pre>
</details>

Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit 6aec722 Nov 20, 2023
18 checks passed
@Psycojoker Psycojoker deleted the Chore/NoCDNLib branch July 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants