Make JAILER_BASE_DIR dependend on execution root

[olethanh]

it was hardcoded before on /var/lib/aleph so it wasn't respecting the proper user settings and was failling if the user didn't have the correct permission for this folder and was producing warning

[github-actions]

• The diff includes a change to the JAILER_BASE_DIRECTORY constant, which is a significant change in the codebase.
• The change also involves modifying the namespace_path property method, which could impact the VM's behavior and might introduce bugs if not handled correctly.
• The reviewer should have deep understanding of the project architecture to ensure that this change does not adversely affect other components.

[olethanh]

I had the impression this path variable wasn't seems to be used consistantly, I.e. we using depending wether we use jailer or not. So doing it this way I feel this is more flexible for latter refactor. Le mer. 22 nov. 2023, 11:04, Hugo Herter ***@***.***> a écrit :

…

***@***.**** commented on this pull request. ------------------------------ In src/aleph/vm/hypervisors/firecracker/microvm.py <#481 (comment)>: > @@ -95,9 +94,13 @@ def __str__(self): return f"vm-{self.vm_id}" @Property - def namespace_path(self): + def jailer_base_directory(self) -> Path: + return self.execution_root_folder / "jailer" Why use this approach instead of building this path in the settings ? — Reply to this email directly, view it on GitHub <#481 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAUERCZ7S3SQ36OSGUX323YFXEZTAVCNFSM6AAAAAA7V5QXQ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBUGAYDKNBTGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[olethanh]

I'm pondering if we should just make a directory per VM and just pass it to the MicroVm under the principle that that class won't make any modifications on disk outside of it. What do you think? Le mer. 22 nov. 2023, 17:57, Olivier Le Thanh Duong ***@***.***> a écrit :

…

I had the impression this path variable wasn't seems to be used consistantly, I.e. we using depending wether we use jailer or not. So doing it this way I feel this is more flexible for latter refactor. Le mer. 22 nov. 2023, 11:04, Hugo Herter ***@***.***> a écrit : > ***@***.**** commented on this pull request. > ------------------------------ > > In src/aleph/vm/hypervisors/firecracker/microvm.py > <#481 (comment)>: > > > @@ -95,9 +94,13 @@ def __str__(self): > return f"vm-{self.vm_id}" > > @Property > - def namespace_path(self): > + def jailer_base_directory(self) -> Path: > + return self.execution_root_folder / "jailer" > > Why use this approach instead of building this path in the settings ? > > — > Reply to this email directly, view it on GitHub > <#481 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAUERCZ7S3SQ36OSGUX323YFXEZTAVCNFSM6AAAAAA7V5QXQ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBUGAYDKNBTGM> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[olethanh]

After discussion with @nesitor did the modification with the settings approach