Fix: Connectivity errors crashed the endpoint #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to retrieve llama text: HTTPConnectionPool(host='46.255.204.205', port=5100): Max retries exceeded with url: /completion (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fcb477f45d0>: Failed to establish a new connection: [Errno 111] Connection refused')) |
MHHukiewitz
approved these changes
Feb 2, 2024
Problem: The endpoint `/status/check/host` should return a data structure with details about the networking that works or does not. When IPv6 connectivity failed due to a connection error, the endpoint crashed with an error 500 instead of returning the expected value `false` for that type of connectivity. Solution: Wrap connectivity errors with a try-catch.
MHHukiewitz
force-pushed
the
hoh-fix-ip-connectivity-crash
branch
from
af33348
to
9215ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The endpoint
/status/check/hostshould return a data structure with details about the networking that works or does not.When IPv6 connectivity failed due to a connection error, the endpoint crashed with an error 500 instead of returning the expected value
falsefor that type of connectivity.Solution: Wrap connectivity errors with a try-catch.