Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Errors in network interface manipulation were invisible #566

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 6, 2024

Solution: Always use check=True to force errors in subprocess.run to raise an error.

Solution: Always use `check=True` to force errors in `subprocess.run` to raise an error.
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 34.57%. Comparing base (b497e9a) to head (5d6f13d).

Files Patch % Lines
src/aleph/vm/network/interfaces.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   34.57%   34.57%           
=======================================
  Files          52       52           
  Lines        4772     4772           
  Branches      558      558           
=======================================
  Hits         1650     1650           
  Misses       3104     3104           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit 0b5e90e into main Mar 6, 2024
20 of 21 checks passed
Copy link

github-actions bot commented Mar 6, 2024

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@Psycojoker Psycojoker deleted the hoh-enforce-command-success branch July 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants