Fix: Tests on Droplets ran even when tests failed #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
Coverage 34.65% 34.65%
=======================================
Files 52 52
Lines 4776 4776
Branches 558 558
=======================================
Hits 1655 1655
Misses 3103 3103
Partials 18 18 ☔ View full report in Codecov by Sentry. |
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Solution: Only run integration tests on Droplets if code quality and pytest succeed.
hoh
force-pushed
the
hoh-droplet-after-tests
branch
from
d9d879d
to
a6df003
Compare
nesitor
approved these changes
Mar 7, 2024
Agreed, a refactoring would be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Only run integration tests on Droplets if code quality and pytest succeed.