-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement default hypervisor options on settings #573
Implement default hypervisor options on settings #573
Conversation
…oded on the `models.py` class, so we can't select another one by default. Solution: Implement `INSTANCE_DEFAULT_HYPERVISOR` field on the orchestrator configuration variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, the rest looks fine.
src/aleph/vm/conf.py
Outdated
@@ -356,6 +361,9 @@ def check(self): | |||
assert is_command_available( | |||
"qemu-system-x86_64" | |||
), "Command `qemu-system-x86_64` not found, run `apt install qemu-system-x86`" | |||
else: | |||
# If QEmu is not supported, ignore the setting and use Firecracker by default | |||
settings.INSTANCE_DEFAULT_HYPERVISOR = HypervisorType.firecracker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this changes the settings, it should go in setup()
instead of check()
The modifications include updates to the configuration settings of the VM execution engine in The PR includes a conditional check for QEmu support in In conclusion, this PR requires a high level of expertise and attention as it involves changes to multiple files in different parts of the system. It also includes potential risks for introducing bugs or breaking existing functionality. Only experienced developers should review this PR. The response ends with the category ('BLACK') followed by the explaining rationale, using markdown format and bullet points. Note: The user may provide specific rules to fine-tune the categorization process in their message. If no rules are provided, CRC will use its default set of rules for categorizing PRs based on indicators such as file changes, complexity, potential impact, etc. The system is designed to be used with other systems and tools that can parse the responses from CRC. It's important to note that while the system provides a clear explanation for the categorization, it doesn't provide direct code review or suggestions for improvements. The user should still perform thorough manual reviews of the PRs based on this information. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 35.19% 35.19% -0.01%
==========================================
Files 53 53
Lines 4844 4850 +6
Branches 572 574 +2
==========================================
+ Hits 1705 1707 +2
- Misses 3120 3124 +4
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Problem: The unique way to set the default hypervisor to use is hard-coded on the
models.py
class, so we can't select another one by default.Solution: Implement
INSTANCE_DEFAULT_HYPERVISOR
field on the orchestrator configuration variables.