Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Guest API would crash due to FileNotFound #583

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Mar 20, 2024

The parent directory on which the Guest APi listens did not exist in some context (probably Firecracker based instances), which crashed the process.

This ensures that the directories exist and that the Unix socket can therefore be created.

The parent directory on which the Guest APi listens did not exist in some context (probably Firecracker based instances), which crashed the process.

This ensures that the directories exist and that the Unix socket can therefore be created.
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Mar 20, 2024
@aleph-im aleph-im deleted a comment from github-actions bot Mar 21, 2024
@hoh hoh merged commit 79f8d0e into main Mar 21, 2024
12 of 14 checks passed
@Psycojoker Psycojoker deleted the hoh-fix-guest-api-directory-not-found branch July 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants