Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform confidential directory on Settings #618

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented May 28, 2024

Problem: The server doesn't have a directory to save the platform certificates generated by sevctl.

Solution: Set that directory field on settings class and ensure to create the folder on initialization step.

…ficates generated by sevctl.

Solution: Set that directory field on settings class and ensure to create the folder on initialization step.
@nesitor nesitor requested review from olethanh and hoh May 28, 2024 19:02
@nesitor nesitor self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.95%. Comparing base (cc3f292) to head (ff5d87b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   57.92%   57.95%   +0.03%     
==========================================
  Files          60       60              
  Lines        5402     5406       +4     
  Branches      600      601       +1     
==========================================
+ Hits         3129     3133       +4     
  Misses       2133     2133              
  Partials      140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label May 28, 2024
@olethanh
Copy link
Collaborator

I'm not actually sure we would need a decitated dir for the certificates, Platform certificate we can just generate in a temporary file or in the main aleph dir (there is only one file now) and certificate we get for the VM should go in the VM directory.

@nesitor
Copy link
Member Author

nesitor commented Jun 3, 2024

I'm not actually sure we would need a decitated dir for the certificates, Platform certificate we can just generate in a temporary file or in the main aleph dir (there is only one file now) and certificate we get for the VM should go in the VM directory.

I think that is better to have it cached, to avoid request it all the time

@olethanh
Copy link
Collaborator

olethanh commented Jun 3, 2024

good point

@aleph-im aleph-im deleted a comment from github-actions bot Jun 3, 2024
@hoh
Copy link
Member

hoh commented Jun 3, 2024

I think that is better to have it cached, to avoid request it all the time

If this data is cached, should it be in CACHE_ROOT instead ?

        if not self.CONFIDENTIAL_DIRECTORY:
            self.CONFIDENTIAL_DIRECTORY = self.CACHE_ROOT / "confidential"

@hoh
Copy link
Member

hoh commented Jun 3, 2024

/var/cache contains data that may be deleted (ex: can be downloaded again or recreated) while /var/lib contains data that may not be lost.

@hoh hoh merged commit b1ca017 into main Jun 5, 2024
23 checks passed
@hoh hoh deleted the andres-feature-add_confidential_directory_setting branch June 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants