Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Websocket were required to fetch logs #645

Merged
merged 14 commits into from
Jul 4, 2024
Merged

Conversation

olethanh
Copy link
Collaborator

Solution: Provide a view that works in get

not sure about the endpoint name.
It's just a proposal to see if it is interesting to have it Still have to fix the style and doc but want to gather your feed back first

src/aleph/vm/utils/logs.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 61.25%. Comparing base (45c14c5) to head (32d682c).

Files Patch % Lines
src/aleph/vm/utils/logs.py 40.00% 6 Missing ⚠️
src/aleph/vm/orchestrator/views/operator.py 91.30% 1 Missing and 1 partial ⚠️
src/aleph/vm/controllers/interface.py 66.66% 1 Missing ⚠️
tests/supervisor/views/test_operator.py 99.04% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   59.94%   61.25%   +1.30%     
==========================================
  Files          64       65       +1     
  Lines        5458     5603     +145     
  Branches      592      596       +4     
==========================================
+ Hits         3272     3432     +160     
+ Misses       2043     2023      -20     
- Partials      143      148       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Solution: Provide a view that works in get

not sure about the endpoint name.
It's just a proposal to see if it is interesting to have it
Still have to fix  the style and doc but want to gather your feed back
first
@olethanh olethanh changed the base branch from ol-fix-systemd-logs to main July 1, 2024 16:04
@olethanh olethanh marked this pull request as ready for review July 1, 2024 16:04
@olethanh
Copy link
Collaborator Author

olethanh commented Jul 1, 2024

I have renamed the endpoint as suggested and added tests for them.

@olethanh olethanh requested a review from hoh July 2, 2024 08:20
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat code. I added two nitpicks, but good overall.

I see a test failing however.

src/aleph/vm/orchestrator/views/operator.py Show resolved Hide resolved
src/aleph/vm/orchestrator/views/operator.py Show resolved Hide resolved
@olethanh olethanh merged commit 4a9eabd into main Jul 4, 2024
24 checks passed
@Psycojoker Psycojoker deleted the ol-new-logs-endpoint branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants