Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Websocket error handling #657

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Jul 17, 2024

Problem: If the frontend or a user send and incorrect auth payload, the endpoint just stop sharing data without return anything or close the connection.

Solution: Handle error issues on the endpoint to always return status field and the reason why it's failing, and closing the connection.

…he endpoint just stop sharing data without return anything or close the connection.

Solution: Handle error issues on the endpoint to always return status field and the reason why it's failing, and closing the connection.
@nesitor nesitor requested review from olethanh and hoh July 17, 2024 10:39
@nesitor nesitor self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.82%. Comparing base (35dd30a) to head (f46d898).

Files Patch % Lines
src/aleph/vm/orchestrator/views/operator.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
+ Coverage   61.75%   61.82%   +0.06%     
==========================================
  Files          68       68              
  Lines        5954     5959       +5     
  Branches      624      624              
==========================================
+ Hits         3677     3684       +7     
+ Misses       2126     2124       -2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor merged commit a27a488 into main Jul 17, 2024
24 checks passed
@nesitor nesitor deleted the andres-fix-solve_websocket_error_handling branch July 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants