Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve Firecracker reboot issues #658

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Jul 17, 2024

Problem: If the frontend or a user send the request to reboot a Firecracker instance, it stops but doesn't start again.

Solution: Change method to restart it just stopping the process, cleaning the firecracker run files and starting it again.

…racker instance, it stops but doesn't start again.

Solution: Change method to restart it just stopping the process, cleaning the firecracker run files and starting it again.
@nesitor nesitor requested review from olethanh and hoh July 17, 2024 11:41
@nesitor nesitor self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.76%. Comparing base (35dd30a) to head (6471d14).

Files Patch % Lines
src/aleph/vm/controllers/__main__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   61.75%   61.76%           
=======================================
  Files          68       68           
  Lines        5954     5955    +1     
  Branches      624      624           
=======================================
+ Hits         3677     3678    +1     
  Misses       2126     2126           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh
Copy link
Collaborator

The lifecyle of the Execution in the different use case are not clear to me. Is the tear down ever called for Firecracker VM when it's running inside systemd?

@nesitor
Copy link
Member Author

nesitor commented Jul 18, 2024

The lifecyle of the Execution in the different use case are not clear to me. Is the tear down ever called for Firecracker VM when it's running inside systemd?

Yes, previously to the PR, the Firecracker VM was removed completely on a service stop or restart. Now is only stopping the process and running it again. Only in the case that the instance is removed completely from the system should do the teardown process.

@nesitor nesitor merged commit e47abd6 into main Jul 23, 2024
24 checks passed
@nesitor nesitor deleted the andres-fix-solve_firecracker_reboot_issues branch July 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants