Provide a template for new PRs #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
=======================================
Coverage 61.46% 61.46%
=======================================
Files 68 68
Lines 5986 5986
Branches 633 633
=======================================
Hits 3679 3679
Misses 2152 2152
Partials 155 155 ☔ View full report in Codecov by Sentry. |
|
What about reusing the template from https://github.com/aleph-im/aleph-client/pull/244/files instead of the generic one ? |
|
It's not generic, I Just opened all the Pr at the same time. Will update this one. |
|
Is there any reason not to merge this one? |
hoh
approved these changes
Aug 28, 2024
|
I restarted the test that failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, providing these informations on each PR should improve review and code quality