Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reuse the id of any vm in pool.executions #672

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

olethanh
Copy link
Collaborator

No description provided.

@olethanh olethanh requested a review from nesitor August 20, 2024 07:49
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.44%. Comparing base (ff6c119) to head (27fc927).
Report is 1 commits behind head on main.

Files Patch % Lines
src/aleph/vm/pool.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   61.43%   61.44%   +0.01%     
==========================================
  Files          68       68              
  Lines        5997     5994       -3     
  Branches      635      635              
==========================================
- Hits         3684     3683       -1     
+ Misses       2158     2156       -2     
  Partials      155      155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoh hoh merged commit 885ff75 into main Aug 20, 2024
26 of 27 checks passed
@hoh hoh deleted the ol-vm-id-reuse branch August 20, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants