Problem: status_check_fastapi endpoint raising eror #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoint `/status/check/fastapi` was raising error when there was no
internet inside vm
This was caused by `check_internet` raising an error instead of just
returning False
Note: Contrarely to what was previously understood the diagnostic vm don't
return a headers when the result is False.
Previous stacktrace
```
ValueError: The server cannot connect to Internet
File "aiohttp/web_app.py", line 537, in _handle
resp = await handler(request)
File "aiohttp/web_middlewares.py", line 114, in impl
return await handler(request)
File "aleph/vm/orchestrator/supervisor.py", line 70, in server_version_middleware
resp: web.StreamResponse = await handler(request)
File "aleph/vm/orchestrator/views/__init__.py", line 215, in status_check_fastapi
"internet": await status.check_internet(session, fastapi_vm_id),
File "aleph/vm/orchestrator/status.py", line 124, in check_internet
raise ValueError("The server cannot connect to Internet")
```
Sentry issue : https://alephim.sentry.io/issues/5654330290/
nesitor
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint
/status/check/fastapiwas raising error when there was no internet inside vmThis was caused by
check_internetraising an error instead of just returning FalseNote: Contrarely to what was previously understood the diagnostic vm don't return a headers when the result is False.
Previous stacktrace
Sentry issue : https://alephim.sentry.io/issues/5654330290/