Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow PAYG on base #685

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Feature: Allow PAYG on base #685

merged 8 commits into from
Sep 3, 2024

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Aug 27, 2024

Problem:
Base chain isn't supported.

Solutions:
adding src/aleph/vm/orchestrator/chain.py to store Available Chains
Display available_payments in status_public_config
Adding checks that the chains sent is in the STREAM_CHAINS

@1yam 1yam marked this pull request as ready for review August 28, 2024 15:52
src/aleph/vm/conf.py Outdated Show resolved Hide resolved
packaging/Makefile Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/aleph/vm/orchestrator/views/__init__.py Outdated Show resolved Hide resolved
@1yam 1yam force-pushed the 1yam-allow-payg-base branch 2 times, most recently from c2536dc to 1a1d98d Compare August 29, 2024 14:18
src/aleph/vm/orchestrator/chain.py Outdated Show resolved Hide resolved
src/aleph/vm/orchestrator/chain.py Outdated Show resolved Hide resolved
src/aleph/vm/orchestrator/chain.py Outdated Show resolved Hide resolved
src/aleph/vm/orchestrator/payment.py Outdated Show resolved Hide resolved
@1yam 1yam requested a review from hoh August 29, 2024 15:55
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1yam and others added 8 commits September 3, 2024 16:32
fix:

Fix: using Chaininfo on settings for better standarization

(TO REVERT)

Refactor: chain management for flow stream

Fix: use chain_info.super_token instead of
settings.PAYMENT_SUPER_TOKEN

Refactor: status_public_config to display AVAILABLE_PAYMENTS instead of  PAYMENT_SUPER_TOKEN and PAYMENT_CHAIN_ID

Feature: allow user to replace RPC with .env RPC_BASE and RPC_AVAX

Feature: add Checks to ensure that the chain is active with superflu in get_stream

Update dependency superfluid to aleph-superfluid==0.2.1
Co-authored-by: nesitor <amolinsdiaz@yahoo.es>

Update pyproject.toml

Co-authored-by: nesitor <amolinsdiaz@yahoo.es>
Co-authored-by: nesitor <amolinsdiaz@yahoo.es>
@olethanh
Copy link
Collaborator

olethanh commented Sep 3, 2024

I rebase it on main

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 63.26531% with 18 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (46063fb) to head (dc4ff37).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/chain.py 73.07% 6 Missing and 1 partial ⚠️
src/aleph/vm/orchestrator/payment.py 40.00% 6 Missing ⚠️
src/aleph/vm/orchestrator/views/__init__.py 20.00% 4 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #685      +/-   ##
==========================================
+ Coverage   62.66%   62.69%   +0.03%     
==========================================
  Files          68       69       +1     
  Lines        6029     6069      +40     
  Branches      638      642       +4     
==========================================
+ Hits         3778     3805      +27     
- Misses       2101     2113      +12     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh olethanh merged commit 02affa3 into main Sep 3, 2024
27 checks passed
@Psycojoker Psycojoker deleted the 1yam-allow-payg-base branch September 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants