Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft schema for a Trip to model flights etc #620

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

sunu
Copy link
Contributor

@sunu sunu commented Mar 16, 2022

How does this look? @brrttwrks @pudo @jlstro @Rosencrantz

Also, what do people think about adding a parent property to Event and Trip so that we can nest events and trips to represent a sequence of events as part of a larger event?

refs #616

@pudo
Copy link
Contributor

pudo commented Mar 16, 2022

Nice work! I wonder if using Address objects on this may be a better path, so that those can be browsed as objects and show their "trips incoming", "trips departing"?

@sunu
Copy link
Contributor Author

sunu commented Mar 16, 2022

Yes, that makes sense. I'll update the schema

@brrttwrks
Copy link
Contributor

I definitely agree with using Address objects. If we are referencing, say, airports, that might be good to show which trips departed or arrived from that address. Also, agree with the parent property - I can definitely see use cases for it and it is a nice way to relate events to super-events or vice versa.

@Rosencrantz Rosencrantz merged commit 89b4f25 into master Mar 29, 2022
@pudo pudo deleted the sunu/trips branch April 19, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants