feat: insert before method element deno dom #76
Conversation
| } else { | ||
| for (let i = 0; i < this.childNodes.length; i++) { | ||
| //TODO: use deep equal or something | ||
| if (this.childNodes[i] === existingNode) { |
There was a problem hiding this comment.
What would be the best way to see if they are equal because === won't work?
| if (!existingNode) { | ||
| return this.appendChild(newNode); | ||
| } else { | ||
| for (let i = 0; i < this.childNodes.length; i++) { |
There was a problem hiding this comment.
I haven't used for loops in such a long time I feel like it isn't looping fully over the this.childNodes, correct me if I am wrong.
There was a problem hiding this comment.
You're doubting me, but I really think it's right.
| @@ -370,4 +370,30 @@ export class Element extends Node { | |||
| } | |||
| return null | |||
| } | |||
|
|
|||
| insertBefore(newNode: Node, existingNode: Node | null) { | |||
There was a problem hiding this comment.
Not ready for merge yet, insertBefore is a Node method so I will move it shortly.
|
@shadowtime2000 , I'm trying to remove the |
good point, closing this PR then. |
Partially resolves #75, implements
insertBeforein theElementclass for SSR.