Revert color updates in favor of global color conversion functions #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 947e208.
not as helpful as i was hoping
bypasses color conversion functions and whatnot
wasn't that slow but, for posterity, why not?
these are barely called, if ever, so let's prefer code simplicity over performance
y,x is RAM order which is like >10x more efficient
we already do this manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides all the common love.graphics color-related functions plus a few other common ones
Not quite ready to merge, there's some regression making characters take several seconds to loadCloses #643
Closes #644
Closes #648