Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add order service #12

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Add order service #12

merged 4 commits into from
Jun 14, 2021

Conversation

maxpautsch
Copy link
Contributor

This pull request adds the possibility to:

  • list all orders
  • get order information
  • change orders
  • export/import authentication sessions

@alex-kn alex-kn self-requested a review June 13, 2021 14:12
alex-kn
alex-kn requested changes Jun 13, 2021
View reviewed changes
Copy link
Owner

@alex-kn alex-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, great changes, thanks for the PR 👍🏽 I especially like the idea of exporting the session for future calls. I left a comment, maybe you could have a look and see what you think.

comdirect_api/comdirect_client.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@alex-kn alex-kn merged commit 9cf0b9b into alex-kn:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-kn alex-kn alex-kn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxpautsch @alex-kn