Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🛠 allow anyio = ">=3.7.1,<5" #2

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

wolfskaempf
Copy link
Contributor

Summary of the changes

  • Change version definition of anyio in pyproject.toml from anyio = "^4" to anyio = ">=3.7.1,<5"

Motivation

Hi @alex-oleshkevich,

thank you for making mailers! In my project I have a dependency on starlette-testclient that relies on anyio of major version 3. mailers currently requires anyio = "^4" and I can therefore not use it together with starlette-testclient (apart from heavily complicating my testing setup by splitting everything into separate virtual environments).

As far as I can tell the only method from anyio that is being used in mailers is open_file in mailers/message.py and mailers/transports/file.py. I have checked the anyio changelog to ensure that open_file did not receive any breaking changes between major version 3 and 4 and could not find any mention of breaking changes to that method. The unit tests are also still passing for both version 3.7.1 of anyio and of course major version 4 as currently inside the pyproject.toml.

Therefore I would like to propose with this Pull Request that mailers changes the version definition of anyio in pyproject.toml from anyio = "^4" to anyio = ">=3.7.1,<5".

Please let me know what you think :)

Greetings and best wishes,
Athena

@alex-oleshkevich alex-oleshkevich merged commit ff7186f into alex-oleshkevich:master Apr 16, 2024
5 of 10 checks passed
@alex-oleshkevich
Copy link
Owner

merged & released.
thanks!

@wolfskaempf
Copy link
Contributor Author

Thank you for the fast response and release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants