Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
anyio
inpyproject.toml
fromanyio = "^4"
toanyio = ">=3.7.1,<5"
Motivation
Hi @alex-oleshkevich,
thank you for making
mailers
! In my project I have a dependency onstarlette-testclient
that relies onanyio
of major version3
.mailers
currently requiresanyio = "^4"
and I can therefore not use it together withstarlette-testclient
(apart from heavily complicating my testing setup by splitting everything into separate virtual environments).As far as I can tell the only method from
anyio
that is being used inmailers
isopen_file
inmailers/message.py
andmailers/transports/file.py
. I have checked theanyio
changelog to ensure thatopen_file
did not receive any breaking changes between major version3
and4
and could not find any mention of breaking changes to that method. The unit tests are also still passing for both version3.7.1
ofanyio
and of course major version4
as currently inside thepyproject.toml
.Therefore I would like to propose with this Pull Request that
mailers
changes the version definition ofanyio
inpyproject.toml
fromanyio = "^4"
toanyio = ">=3.7.1,<5"
.Please let me know what you think :)
Greetings and best wishes,
Athena