Move custom operator handling to scanner.c
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom operator rules are better expressed as conditions to track in `eat_operator` vs a series of impenetrable regexes. Also requires a fix for an undiscovered bug where `x[...]!` was not considered to be a legal target for an expression. Since the old logic allowed `+=` to be a "custom operator", we were covering up for that failure by interpreting `x[...]! += y` as a custom infix expression. Fixes #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom operator rules are better expressed as conditions to track in
eat_operatorvs a series of impenetrable regexes.Also requires a fix for an undiscovered bug where
x[...]!was not considered to be a legal target for an expression. Since the old logic allowed+=to be a "custom operator", we were covering up for that failure by interpretingx[...]! += yas a custom infix expression.This fixes the last parse failure in the current list of top repos, so we also bring in some new top repos. The new list comes from the ones the Semgrep folks have added for their own parse rate tracking. For some reason, Semgrep uses very old repos, so we have to support older language constructs.
Fixes #5