Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle updates to Source tileJsonSource prop more gracefully #914

Merged
merged 5 commits into from
Nov 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion example/generateRaws.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ const files = [
'htmlCluster.tsx',
'switchStyle.tsx',
'geojsonLayer.tsx',
'heatmap.tsx'
'heatmap.tsx',
'vectorLayer.tsx'
];

files.forEach((file) => {
Expand Down
125 changes: 125 additions & 0 deletions example/src/demos/raws/vectorLayer.raw
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
import * as React from 'react';
import ReactMapboxGl, { Layer, Source } from '../../../';

import styled from 'styled-components';

// tslint:disable-next-line:no-var-requires
const { token, styles } = require('./config.json');

const Map = ReactMapboxGl({ accessToken: token });

const Container = styled.div`
position: relative;
height: 100%;
flex: 1;
`;

const Button = styled.button`
border: 1px solid #3770c6;
background-color: rgb(84, 152, 255);
height: 100%;
color: white;
font-size: 13px;
padding: 6px 12px;
border-radius: 6px;
cursor: pointer;
outline: none;
:hover {
background-color: #3770c6;
}
`;
const Indicator = styled.div`
padding: 6px 10px;
background-color: white;
`;
const BottomBar = styled.div`
position: absolute;
bottom: 20px;
left: 20px;
right: 20px;
height: 40px;
display: flex;
justify-content: space-between;
align-items: center;
`;

const mapStyle = {
height: '100%',
width: '100%'
};

export interface Props {
// tslint:disable-next-line:no-any
onStyleLoad?: (map: any) => any;
}

const lineLayout = {
'line-cap': 'round' as 'round',
'line-join': 'round' as 'round'
};

const linePaint = {
'line-color': '#4790E5',
'line-width': 2
};

export interface State {
render: 'cloudfront' | 'mapillary';
}

export default class VectorLayer extends React.Component<Props> {
public state: State = {
render: 'mapillary'
};

// tslint:disable-next-line:no-any
private onStyleLoad = (map: any) => {
const { onStyleLoad } = this.props;
return onStyleLoad && onStyleLoad(map);
};

public render() {
const { render } = this.state;
const tileUrl =
render === 'mapillary'
? 'https://tiles3.mapillary.com/v0.1/{z}/{x}/{y}.mvt'
: 'https://d25uarhxywzl1j.cloudfront.net/v0.1/{z}/{x}/{y}.mvt';

return (
<Container>
<Map
style={styles.dark}
containerStyle={mapStyle}
onStyleLoad={this.onStyleLoad}
>
<Source
id="mapillary"
tileJsonSource={{
type: 'vector',
tiles: [tileUrl],
minzoom: 6,
maxzoom: 14
}}
/>
<Layer
id="mapillary"
type="line"
source="mapillary"
sourceLayer="mapillary-sequences"
layout={lineLayout}
paint={linePaint}
/>
</Map>
<BottomBar>
<Button onClick={() => this.setState({ render: 'mapillary' })}>
Mapillary
</Button>
<Button onClick={() => this.setState({ render: 'cloudfront' })}>
Cloudfront
</Button>
<Indicator>Using tiles from {render}</Indicator>
</BottomBar>
</Container>
);
}
}
9 changes: 9 additions & 0 deletions example/src/demos/sections.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import ThreeDMap from './threeDMap';
import HtmlCluster from './htmlCluster';
import SwitchStyle from './switchStyle';
import GeoJsonLayer from './geojsonLayer';
import VectorLayer from './vectorLayer';
import Heatmap from './heatmap';
import { Live } from '../live';
import raw from 'raw.macro';
Expand All @@ -18,6 +19,7 @@ const HtmlClusterRaw = raw('./raws/htmlCluster.raw');
const SwitchStyleRaw = raw('./raws/switchStyle.raw');
const GeoJsonLayerRaw = raw('./raws/geojsonLayer.raw');
const HeatmapRaw = raw('./raws/heatmap.raw');
const VectorLayerRaw = raw('./raws/vectorLayer.raw');

export const sections = [
{
Expand Down Expand Up @@ -82,5 +84,12 @@ export const sections = [
components: ['ReactMapboxGl', 'GeoJsonLayer'],
DemoComponent: GeoJsonLayer,
reactLive: <Live full={true} raw={GeoJsonLayerRaw} />
},
{
shortTitle: 'vector-source',
title: 'Display data from vector tile',
components: ['ReactMapboxGl', 'Source', 'Layer'],
DemoComponent: VectorLayer,
reactLive: <Live full={true} raw={VectorLayerRaw} />
}
];
125 changes: 125 additions & 0 deletions example/src/demos/vectorLayer.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
import * as React from 'react';
import ReactMapboxGl, { Layer, Source } from '../../../';

import styled from 'styled-components';

// tslint:disable-next-line:no-var-requires
const { token, styles } = require('./config.json');

const Map = ReactMapboxGl({ accessToken: token });

const Container = styled.div`
position: relative;
height: 100%;
flex: 1;
`;

const Button = styled.button`
border: 1px solid #3770c6;
background-color: rgb(84, 152, 255);
height: 100%;
color: white;
font-size: 13px;
padding: 6px 12px;
border-radius: 6px;
cursor: pointer;
outline: none;
:hover {
background-color: #3770c6;
}
`;
const Indicator = styled.div`
padding: 6px 10px;
background-color: white;
`;
const BottomBar = styled.div`
position: absolute;
bottom: 20px;
left: 20px;
right: 20px;
height: 40px;
display: flex;
justify-content: space-between;
align-items: center;
`;

const mapStyle = {
height: '100%',
width: '100%'
};

export interface Props {
// tslint:disable-next-line:no-any
onStyleLoad?: (map: any) => any;
}

const lineLayout = {
'line-cap': 'round' as 'round',
'line-join': 'round' as 'round'
};

const linePaint = {
'line-color': '#4790E5',
'line-width': 2
};

export interface State {
render: 'cloudfront' | 'mapillary';
}

export default class VectorLayer extends React.Component<Props> {
public state: State = {
render: 'mapillary'
};

// tslint:disable-next-line:no-any
private onStyleLoad = (map: any) => {
const { onStyleLoad } = this.props;
return onStyleLoad && onStyleLoad(map);
};

public render() {
const { render } = this.state;
const tileUrl =
render === 'mapillary'
? 'https://tiles3.mapillary.com/v0.1/{z}/{x}/{y}.mvt'
: 'https://d25uarhxywzl1j.cloudfront.net/v0.1/{z}/{x}/{y}.mvt';

return (
<Container>
<Map
style={styles.dark}
containerStyle={mapStyle}
onStyleLoad={this.onStyleLoad}
>
<Source
id="mapillary"
tileJsonSource={{
type: 'vector',
tiles: [tileUrl],
minzoom: 6,
maxzoom: 14
}}
/>
<Layer
id="mapillary"
type="line"
source="mapillary"
sourceLayer="mapillary-sequences"
layout={lineLayout}
paint={linePaint}
/>
</Map>
<BottomBar>
<Button onClick={() => this.setState({ render: 'mapillary' })}>
Mapillary
</Button>
<Button onClick={() => this.setState({ render: 'cloudfront' })}>
Cloudfront
</Button>
<Indicator>Using tiles from {render}</Indicator>
</BottomBar>
</Container>
);
}
}
29 changes: 19 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"supercluster": "^7.0.0"
},
"peerDependencies": {
"mapbox-gl": "^1.10.1",
"mapbox-gl": "^1.12.0",
"prop-types": "^15.6.2",
"react": "^16.11.0",
"react-dom": "^16.11.0"
Expand All @@ -84,7 +84,7 @@
"@types/enzyme-adapter-react-16": "^1.0.3",
"@types/geojson": "7946.0.4",
"@types/jest": "24.0.19",
"@types/mapbox-gl": "^1.10.2",
"@types/mapbox-gl": "^1.12.8",
"@types/node": "8.0.29",
"@types/prettier": "1.10.0",
"@types/prop-types": "15.5.6",
Expand All @@ -95,7 +95,7 @@
"enzyme-adapter-react-16": "1.6.0",
"husky": "^0.14.3",
"jest": "24.9.0",
"mapbox-gl": "^1.10.1",
"mapbox-gl": "^1.12.0",
"prettier": "1.10.2",
"prop-types": "15.6.2",
"react": "^16.11.0",
Expand Down
Loading