Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(beforeDestroy): Update beforeDestroy hook to be beforeUnmount #27

Merged
merged 1 commit into from
Oct 5, 2021
Merged

update(beforeDestroy): Update beforeDestroy hook to be beforeUnmount #27

merged 1 commit into from
Oct 5, 2021

Conversation

haritha2112
Copy link
Contributor

@haritha2112 haritha2112 commented Oct 4, 2021 •
edited
Loading

Issue:

The lifecycle hook beforeDestroy which is being used in src/legacy/mixin.ts is no longer supported in Vue 3.

Fix

Updated beforeDestroy to be beforeUnmount so that it is Vue3 compatible

Closes #28

@haritha2112 haritha2112 marked this pull request as draft October 4, 2021 20:24
@haritha2112 haritha2112 marked this pull request as ready for review October 4, 2021 20:28
@alexander-heimbuch
Copy link
Owner

lgtm 👍

@alexander-heimbuch alexander-heimbuch merged commit 2295211 into alexander-heimbuch:master Oct 5, 2021
@alexander-heimbuch
Copy link
Owner

published as v3.0.0-beta.6

@haritha2112 haritha2112 deleted the vue3/beforeDestroy branch October 5, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-heimbuch alexander-heimbuch alexander-heimbuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifecycle hook beforeDestroy is no longer supported in Vue 3
2 participants
@haritha2112 @alexander-heimbuch