Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add configurable storage directory that defaults to `node_mod… #158

Merged
merged 1 commit into from
Jul 29, 2016

Conversation

alexanderGugel
Copy link
Owner

~/r/i/example (fix-dir) $ env NODE_DEBUG=install ied i is-array
🕐  INSTALL 47919: extracting dependencies,devDependencies,optionalDependencies from ../..
INSTALL 47919: resolving is-array@*
INSTALL 47919: resolving /Users/alex/repos/ied/node_modules/is-array from node_modules
INSTALL 47919: failed to resolve is-array@* from local ../.. via /Users/alex/repos/ied/example/node_modules
INSTALL 47919: resolving is-array@* from remote registry
INSTALL 47919: resolving is-array@* from npm
🕒  0% resolving is-array@*INSTALL 47919: resolved is-array@* to tarball shasum e9850cc2cc860c3bc0977e84ccf0dd464584279a from npm
INSTALL 47919: symlinking .cas/e9850cc2cc860c3bc0977e84ccf0dd464584279a/package -> node_modules/is-array
INSTALL 47919: fetching http://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz into /Users/alex/repos/ied/example/node_modules/.cas/e9850cc2cc860c3bc0977e84ccf0dd464584279a/package
INSTALL 47919: extracting dependencies,optionalDependencies from e9850cc2cc860c3bc0977e84ccf0dd464584279a
INSTALL 47919: fixing persmissions of  in /Users/alex/repos/ied/example/node_modules/.cas/e9850cc2cc860c3bc0977e84ccf0dd464584279a/package
INSTALL 47919: downloading http://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz, expecting e9850cc2cc860c3bc0977e84ccf0dd464584279a
INSTALL 47919: downloaded e9850cc2cc860c3bc0977e84ccf0dd464584279a into /Users/alex/.ied_cache/.tmp/6e8512f3-1e4e-4231-a17c-59e0344fdcad

ied was installing the dependencies into the wrong directory:

See INSTALL 47919: resolving /Users/alex/repos/ied/node_modules/is-array from node_modules

pwd:

~/r/i/example (fix-dir) $ pwd
/Users/alex/repos/ied/example

After revert:

INSTALL 48165: resolving /Users/alex/repos/ied/example/node_modules/tape from node_modules

I'm reverting this for now to unbreak things, I still think the .cad is a great idea.
cc @mgcrea

@alexanderGugel alexanderGugel merged commit 2f1c439 into master Jul 29, 2016
@alexanderGugel alexanderGugel deleted the fix-dir branch July 29, 2016 00:56
@mgcrea
Copy link
Collaborator

mgcrea commented Aug 3, 2016

Indeed it looks like it was not properly resolving already installed deps! Sorry for letting that through. Had it work with both big frontend and backend projects so I assumed everything was fine. Looks like post first install operations would miss the installed deps.

I'm looking into it atm, main issue is the split between entry deps and non-entry deps stored inside the .cas folder. I'm trying to find a solution that minimize refactoring, but it may need a bigger change that what I hoped for.

I'm currently away for vacations but I do hope to have it working soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants