Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial unit test with Jest #14

Merged
merged 2 commits into from
Oct 27, 2024
Merged

feat: initial unit test with Jest #14

merged 2 commits into from
Oct 27, 2024

Conversation

alexanderscheibler
Copy link
Owner

@alexanderscheibler alexanderscheibler commented Oct 27, 2024

  • Configures Jest for unit testing
  • Add Github Action for Jest
  • Add unit tests for the Header component
  • Define ScreenSizes on file on the "data/" folder, for easy reuse across the tests.
  • Refactor some components, moving their data to the "data/" folder. Examples: Nav links, Helper cards.
  • Refactor Header, particularly for mobile. Changes:
  1. Instead of horizontal stack (which would create an horizontal scroll or have items out of screen as the menu grows), have items in vertical stack)
    Before / After
image image
  1. Collapse the menu after an item is selected, so the user can see the full page / item

  2. Have both mobile and desktop menu share the same array data for easy of update, instead of having the items hard coded twice.

@alexanderscheibler alexanderscheibler merged commit d4c9790 into main Oct 27, 2024
1 check passed
@alexanderscheibler alexanderscheibler deleted the jest branch October 27, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant