Muse lsl connection timeout argument #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umentatino for -t argument and timout parser for arguments
aureateAnatidae
changed the title
|
I fear I've messed something up. Could someone confirm that this is happening? Removing the int(self.timeout) from the logger.info line in cli.py seems to help. |
|
Uh, this is a bit embarrassing, but I shadowed the |
jdpigeon
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either my laptop is slow or it's because I have an original muse, it seems to have an issue timing out before it can establish a connection. This pull request adds a -t --timeout argument to the argument parser, allowing my machine to try connecting for longer before the timeout argument.
Also, a variable setting the default timeout length
AUTO_DISCONNECT_DELAYin constants.py was commented out, and its only use was in stream.py has been deleted. The default timeout length was set in the argument parsers in cli.py (10.0) to relieve its role. Please be wary that the connection timeout and scan timeout are different variables addressed by the same name. This pull request addresses the former.I only have the means to test this with bluetoothctl/bleak, so I'm kinda just hoping it doesn't break something sending a timeout argument to gatt or hci or windows or something. I've been using python 3.11 on Debian 12, bluetoothctl 5.66.
I've never done this kind of open-source thing, so please provide advice liberally :).
Should resolve #178
Hadn't noticed this other person's issue before, but glad someone else mentioned it.