Skip to content

Commit

Permalink
Auto merge of rust-lang#6080 - matthiaskrgr:jq_comment, r=dwijnand
Browse files Browse the repository at this point in the history
job queue: remove outdated comment about reenabling compile-progress once rust-lang#5695 is fixed

The issue has been resolved and the compile-progress has been reenabled already.
  • Loading branch information
bors committed Sep 23, 2018
2 parents 0dd3f8f + 9f51454 commit 650b5d8
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/cargo/core/compiler/job_queue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,17 +225,6 @@ impl<'a> JobQueue<'a> {
// After a job has finished we update our internal state if it was
// successful and otherwise wait for pending work to finish if it failed
// and then immediately return.
//
// TODO: the progress bar should be re-enabled but unfortunately it's
// difficult to do so right now due to how compiler error messages
// work. Cargo doesn't redirect stdout/stderr of compiler
// processes so errors are not captured, and Cargo doesn't know
// when an error is being printed, meaning that a progress bar
// will get jumbled up in the output! To reenable this progress
// bar we'll need to probably capture the stderr of rustc and
// capture compiler error messages, but that also means
// reproducing rustc's styling of error messages which is
// currently a pretty big task. This is issue #5695.
let mut error = None;
let mut progress = Progress::with_style("Building", ProgressStyle::Ratio, cx.bcx.config);
let total = self.queue.len();
Expand Down

0 comments on commit 650b5d8

Please sign in to comment.