Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide custom header callback in addition to progress #102

Closed
wants to merge 1 commit into from

Conversation

xen0n
Copy link

@xen0n xen0n commented Apr 25, 2016

This feature seems necessary for implementing rust-lang/rustup#344, as curl_easy_perform is blocking.

I particularly don't like the name for the new builder method header_cb because it clashes with headers, but I couldn't immediately come up with a better name. Any suggestions on this?

BTW I'm relatively new to Rust (haven't used it for almost 1 year), so please kindly point out any mistake I might have made. Thanks!

@alexcrichton
Copy link
Owner

Hey @xen0n , I'm taking over the curl crate for now and I've got an API rewrite over at #105 which I believe should address this as well. If you'd like to take a look though feel free!

@xen0n
Copy link
Author

xen0n commented May 13, 2016

@alexcrichton I took a glimpse and it's an elegant API! Very close to C API and almost every feature is exposed. I will close this PR favoring the API you suggested instead.

Great work! 😃

@xen0n xen0n closed this May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants