Enable HAVE_GETPEERNAME when building curl
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this enables a few optimizations internally, such as reusing connections! Let's be sure to enable this for our platforms, which should all have this, so we can get those performance optimizations with HTTP.
|
For some background on this, I've been debugging why a |
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this pull request
Oct 1, 2019
Pulls in alexcrichton/curl-rust#304 which fixes a bug from the last curl update in rust-lang#7308. This bug was not introduced by the Cargo PR itself but rather by updating the `curl` submodule in the `curl-sys` crate. Without this bugfix all downloads of a crate will make a new connection to crates.io, which drastically increases download time since setting up a connection takes so long.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Oct 2, 2019
Update `curl-sys` dependency requirement Pulls in alexcrichton/curl-rust#304 which fixes a bug from the last curl update in #7308. This bug was not introduced by the Cargo PR itself but rather by updating the `curl` submodule in the `curl-sys` crate. Without this bugfix all downloads of a crate will make a new connection to crates.io, which drastically increases download time since setting up a connection takes so long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this enables a few optimizations internally, such as reusing
connections! Let's be sure to enable this for our platforms, which
should all have this, so we can get those performance optimizations with
HTTP.