Don't set a default whole request timeout. #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And if you merge this, could you please also bump the version on crates.io? I'm unable to compile cargo on a slow connection because of this. |
|
/ping |
|
r? @carllerche |
|
Pretty late, but I don't personally have a huge opinion. I don't like having unlimited timeouts. I think @alexcrichton likes having a 30 second default timeout. |
|
Hey @utkarshkukreti, I'm taking over the curl crate for now and I've got an API rewrite over at #105 which I believe should address this as well. If you'd like to take a look though feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think a binding should set such a low value (or any value) by default.
http://curl.haxx.se/libcurl/c/CURLOPT_TIMEOUT_MS.html