Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use vcpkg only for *-msvc targets #556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ognevny
Copy link

@ognevny ognevny commented Mar 26, 2024

for other windows targets (*-gnu and *-gnullvm) pkg-config is usually used

@ognevny ognevny changed the title use vcpkg only from *-msvc targets use vcpkg only for *-msvc targets Mar 26, 2024
@ognevny
Copy link
Author

ognevny commented Nov 27, 2024

I've rebased branch and simplified patch a bit
@alexcrichton can this be merged? I see other -sys crates use vcpkg for MSVC only

@alexcrichton
Copy link
Owner

I'm sorry but I don't personally have the energy to shepherd this. Changes like this unfortunately have a pretty high likelihood of causing breakage for users. That breakage typically requires follow-ups from the maintainership side here which I don't have a ton of time for nowadays. If someone else wants to champion this though and field requests though that's ok too! (they'll need to merge though)

@ognevny
Copy link
Author

ognevny commented Dec 3, 2024

we can change it to run both vcpkg and pkg-config on windows-gnu. it shouldn't break "pure" msys2 environments (like CIs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants