Skip to content

Commit

Permalink
Remove check-fast. Closes rust-lang#4193, rust-lang#8844, rust-lang#6330
Browse files Browse the repository at this point in the history
  • Loading branch information
brson authored and alexcrichton committed Apr 6, 2014
1 parent 31e8f24 commit 072a920
Show file tree
Hide file tree
Showing 311 changed files with 172 additions and 465 deletions.
65 changes: 4 additions & 61 deletions mk/tests.mk
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ check-ref: cleantestlibs cleantmptestlogs check-stage2-rpass \
check-docs: cleantestlibs cleantmptestlogs check-stage2-docs
$(Q)$(CFG_PYTHON) $(S)src/etc/check-summary.py tmp/*.log

# NOTE: Remove after reprogramming windows bots
check-fast: check-lite

.PHONY: cleantmptestlogs cleantestlibs

cleantmptestlogs:
Expand Down Expand Up @@ -875,69 +878,9 @@ $(foreach crate,$(TEST_CRATES), \
$(eval $(call DEF_CHECK_CRATE,$(crate))))

######################################################################
# check-fast rules
# RMAKE rules
######################################################################

FT := run_pass_stage2
FT_LIB := $(call CFG_LIB_NAME_$(CFG_BUILD),$(FT))
FT_DRIVER := $(FT)_driver

GENERATED += tmp/$(FT).rc tmp/$(FT_DRIVER).rs

tmp/$(FT).rc tmp/$(FT_DRIVER).rs: \
$(RPASS_TESTS) \
$(S)src/etc/combine-tests.py
@$(call E, check: building combined stage2 test runner)
$(Q)$(CFG_PYTHON) $(S)src/etc/combine-tests.py

define DEF_CHECK_FAST_FOR_T_H
# $(1) unused
# $(2) target triple
# $(3) host triple

$$(TLIB2_T_$(2)_H_$(3))/$$(FT_LIB): \
tmp/$$(FT).rc \
$$(SREQ2_T_$(2)_H_$(3))
@$$(call E, oxidize: $$@)
$$(STAGE2_T_$(2)_H_$(3)) --crate-type=dylib --out-dir $$(@D) $$< \
-L "$$(RT_OUTPUT_DIR_$(2))"

$(3)/test/$$(FT_DRIVER)-$(2)$$(X_$(2)): \
tmp/$$(FT_DRIVER).rs \
$$(TLIB2_T_$(2)_H_$(3))/$$(FT_LIB) \
$$(SREQ2_T_$(2)_H_$(3))
@$$(call E, oxidize: $$@ $$<)
$$(STAGE2_T_$(2)_H_$(3)) -o $$@ $$< \
-L "$$(RT_OUTPUT_DIR_$(2))"

$(3)/test/$$(FT_DRIVER)-$(2).out: \
$(3)/test/$$(FT_DRIVER)-$(2)$$(X_$(2)) \
$$(SREQ2_T_$(2)_H_$(3))
$$(Q)$$(call CFG_RUN_TEST_$(2),$$<,$(2),$(3)) \
--logfile tmp/$$(FT_DRIVER)-$(2).log

check-fast-T-$(2)-H-$(3): \
$(3)/test/$$(FT_DRIVER)-$(2).out

endef

$(foreach host,$(CFG_HOST), \
$(eval $(foreach target,$(CFG_TARGET), \
$(eval $(call DEF_CHECK_FAST_FOR_T_H,,$(target),$(host))))))

check-fast: tidy check-fast-H-$(CFG_BUILD) \
$(foreach crate,$(TARGET_CRATES),check-stage2-$(crate))
$(Q)$(CFG_PYTHON) $(S)src/etc/check-summary.py tmp/*.log

define DEF_CHECK_FAST_FOR_H

check-fast-H-$(1): check-fast-T-$(1)-H-$(1)

endef

$(foreach host,$(CFG_HOST), \
$(eval $(call DEF_CHECK_FAST_FOR_H,$(host))))

RMAKE_TESTS := $(shell ls -d $(S)src/test/run-make/*/)
RMAKE_TESTS := $(RMAKE_TESTS:$(S)src/test/run-make/%/=%)

Expand Down
91 changes: 0 additions & 91 deletions src/etc/combine-tests.py

This file was deleted.

5 changes: 5 additions & 0 deletions src/etc/maketest.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
import os
import sys

# FIXME #12303 these tests are broken on windows
if os.name == 'nt':
print 'ignoring make tests on windows'
sys.exit(0)

os.putenv('RUSTC', os.path.abspath(sys.argv[2]))
os.putenv('TMPDIR', os.path.abspath(sys.argv[3]))
os.putenv('CC', sys.argv[4])
Expand Down
1 change: 0 additions & 1 deletion src/test/auxiliary/crateresolve7x.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast
// aux-build:crateresolve_calories-1.rs
// aux-build:crateresolve_calories-2.rs

Expand Down
1 change: 0 additions & 1 deletion src/test/auxiliary/issue-2414-b.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast

#[crate_id="b#0.1"];
#[crate_type = "lib"];
Expand Down
1 change: 0 additions & 1 deletion src/test/auxiliary/issue-9906.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast windows doesn't like extern crate
// aux-build:issue-9906.rs

pub use other::FooBar;
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/ambig_impl_2_exe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast aux-build
// aux-build:ambig_impl_2_lib.rs
extern crate ambig_impl_2_lib;
use ambig_impl_2_lib::me;
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/asm-in-bad-modifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast #[feature] doesn't work with check-fast
#![feature(asm)]

fn foo(x: int) { println!("{}", x); }
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/asm-misplaced-option.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast #[feature] doesn't work with check-fast
// ignore-android

#![feature(asm)]
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/asm-out-assign-imm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast #[feature] doesn't work with check-fast
#![feature(asm)]

fn foo(x: int) { println!("{}", x); }
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/asm-out-no-modifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast #[feature] doesn't work with check-fast
#![feature(asm)]

fn foo(x: int) { println!("{}", x); }
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/asm-out-read-uninit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast #[feature] doesn't work with check-fast
#![feature(asm)]

fn foo(x: int) { println!("{}", x); }
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/builtin-superkinds-in-metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast

// aux-build:trait_superkinds_in_metadata.rs

Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/coherence_inherent_cc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast
// aux-build:coherence_inherent_cc_lib.rs

// Tests that methods that implement a trait cannot be invoked
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/crateresolve5.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast
// aux-build:crateresolve5-1.rs
// aux-build:crateresolve5-2.rs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

// issue 7327

// ignore-fast #7103
extern crate sync;

use sync::Arc;

struct A { y: Arc<int>, x: Arc<int> }
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/gated-non-ascii-idents.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast feature doesn't work.

#![feature(struct_variant)]

Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/gated-trace_macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast feature doesn't work.

fn main() {
trace_macros!(true); //~ ERROR: `trace_macros` is not stable
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/lint-stability.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast aux-build
// aux-build:lint_stability.rs

#![feature(globs)]
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/private-method-cross-crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast
// aux-build:cci_class_5.rs
extern crate cci_class_5;
use cci_class_5::kitties::cat;
Expand Down
29 changes: 29 additions & 0 deletions src/test/compile-fail/redundant-link-args.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-test

// error-pattern:library 'm' already added: can't specify link_args.

/* I think it should undefined to have multiple modules that link in the same
library, but provide different link arguments. Unfortunately we don't track
link_args by module -- they are just appended as discovered into the crate
store -- but for now, it should be an error to provide link_args on a module
that's already been included (with or without link_args). */

#[link_name= "m"]
#[link_args="-foo"] // this could have been elided.
extern {
}

#[link_name= "m"]
#[link_args="-bar"] // this is the actual error trigger.
extern {
}
1 change: 0 additions & 1 deletion src/test/compile-fail/xc-private-method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast
// aux-build:xc_private_method_lib.rs

extern crate xc_private_method_lib;
Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail/xc-private-method2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast
// aux-build:xc_private_method_lib.rs

extern crate xc_private_method_lib;
Expand Down
1 change: 0 additions & 1 deletion src/test/pretty/raw-str-nonexpr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-fast #[feature] doesn't work with check-fast
// pp-exact

#![feature(asm)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

// aux-build:macro_crate_outlive_expansion_phase.rs
// ignore-stage1
// ignore-fast
// ignore-android
// ignore-cross-compile #12102

Expand Down
1 change: 0 additions & 1 deletion src/test/run-pass-fulldeps/macro-crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

// aux-build:macro_crate_test.rs
// ignore-stage1
// ignore-fast
// ignore-android
// ignore-cross-compile #12102

Expand Down
Loading

0 comments on commit 072a920

Please sign in to comment.