Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setAuthor() method doesn't work on Feed #200

Closed
karllhughes opened this issue Feb 7, 2019 · 3 comments
Closed

setAuthor() method doesn't work on Feed #200

karllhughes opened this issue Feb 7, 2019 · 3 comments

Comments

@karllhughes
Copy link

I noticed in the spec that setAuthor() should work for the Feed object, but I am getting Call to undefined method FeedIo\Feed::setAuthor() when I try to use it.

I also can't find the method in the Feed code, so I'm guessing it's either a documentation error or an oversite. I'd be interested in making a PR to add it if you'd like?

@alexdebril
Copy link
Owner

It's a documentation error sorry, I think the set/getAuthor methods should be in \FeedIo\Feed\Node.

I remember having removed it some while ago, let me have a look at it to figure out why I did that. I'll catch up with you then.

@karllhughes
Copy link
Author

Sounds good.

This could be an RSS/Atom difference as RSS 2.0 doesn't have a feed-level author.

@alexdebril
Copy link
Owner

Sorry I didn't get back to you earlier.

You can send a PR if you want, the thing you need to be careful about is the difference between Atom and RSS standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants