Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add labctl to tools #1121

Merged
merged 1 commit into from
Sep 29, 2024
Merged

feat: add labctl to tools #1121

merged 1 commit into from
Sep 29, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Sep 29, 2024

Description

Motivation and Context

How Has This Been Tested?

Functional

➜  arkade git:(addLabctl) ✗ ./arkade get labctl
Downloading: labctl
2024/09/29 08:09:51 Looking up version for labctl
2024/09/29 08:09:51 Found: v0.1.8
Downloading: https://github.com/iximiuz/labctl/releases/download/v0.1.8/labctl_darwin_arm64.tar.gz
3.75 MiB / 3.75 MiB [------------------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3122922133/labctl_darwin_arm64.tar.gz written.
2024/09/29 08:09:52 Extracted: /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3122922133/labctl
2024/09/29 08:09:52 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3122922133/labctl to /Users/rgee0/.arkade/bin/labctl

Wrote: /Users/rgee0/.arkade/bin/labctl (10.04MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/labctl

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/labctl /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis

make e2e

➜  arkade git:(addLabctl) make e2e 
CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
...
PASS
coverage: 61.4% of statements
ok  	github.com/alexellis/arkade/pkg/get	11.499s	coverage: 61.4% of statements

test-tool

404 for arm64/linux and windows is to be expected as only three binaries are provided by the project

➜  arkade git:(addLabctl) ✗ ./hack/test-tool.sh labctl                  
+ ./arkade get labctl --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/labctl
/Users/rgee0/.arkade/bin/labctl: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/labctl
+ echo

+ ./arkade get labctl --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/labctl
/Users/rgee0/.arkade/bin/labctl: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/labctl
+ echo

+ ./arkade get labctl --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/labctl
/Users/rgee0/.arkade/bin/labctl: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=N-wCX2ZCOQodVI3nE40b/fGBBClGPVWk-HCFn6UjQ/ClrZeruPWUht1VtkinxR/I-KQk-e8MG2W4qu1Dnf8, stripped
+ rm /Users/rgee0/.arkade/bin/labctl
+ echo

+ ./arkade get labctl --arch aarch64 --os linux --quiet

The requested version of labctl is not available or configured in arkade for linux/aarch64

* Check if a binary is available from the project for your Operating System
* View the labctl releases page: https://github.com/iximiuz/labctl/releases
* Feel free to raise an issue at https://github.com/alexellis/arkade/issues for help

Error: server returned status: 404

+ ./arkade get labctl --arch x86_64 --os mingw --quiet

The requested version of labctl is not available or configured in arkade for mingw/x86_64

* Check if a binary is available from the project for your Operating System
* View the labctl releases page: https://github.com/iximiuz/labctl/releases
* Feel free to raise an issue at https://github.com/alexellis/arkade/issues for help

Error: server returned status: 404

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Richard Gee <richard@technologee.co.uk>
@alexellis
Copy link
Owner

Thank you for adding this Richard

@alexellis alexellis merged commit 0f87fbd into alexellis:master Sep 29, 2024
2 checks passed
@iximiuz
Copy link

iximiuz commented Sep 30, 2024

Thanks a lot for making it happen, @rgee0! 🙌

@rgee0 rgee0 deleted the addLabctl branch September 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labctl tool for iximiuz.com labs
3 participants