Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add duplik8s to tools #1124

Merged
merged 1 commit into from
Oct 26, 2024
Merged

feat: add duplik8s to tools #1124

merged 1 commit into from
Oct 26, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Oct 17, 2024

Description

Adds https://github.com/Telemaco019/duplik8s to the growing list of tools

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer

Via Discord

How Has This Been Tested?

Functional

➜  arkade git:(addDuplik8s) ✗ ./arkade get duplik8s
Downloading: duplik8s
2024/10/17 12:14:27 Looking up version for duplik8s
2024/10/17 12:14:28 Found: v0.3.0
Downloading: https://github.com/Telemaco019/duplik8s/releases/download/v0.3.0/duplik8s_Darwin_arm64.tar.gz
12.61 MiB / 12.61 MiB [----------------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2789515258/duplik8s_Darwin_arm64.tar.gz written.
2024/10/17 12:14:29 Extracted: /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2789515258/duplik8s
2024/10/17 12:14:29 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-2789515258/duplik8s to /Users/rgee0/.arkade/bin/duplik8s

Wrote: /Users/rgee0/.arkade/bin/duplik8s (46.71MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/duplik8s

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/duplik8s /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis

make E2E

➜  arkade git:(addDuplik8s) ✗ make e2e > test.out
CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
...
--- PASS: Test_CheckTools (0.00s)
    --- PASS: Test_CheckTools/Download_of_duplik8s (0.73s)
...
PASS
coverage: 61.4% of statements
ok  	github.com/alexellis/arkade/pkg/get	11.531s	coverage: 61.4% of statements

test-tool

➜  arkade git:(addDuplik8s) ✗ ./hack/test-tool.sh duplik8s
+ ./arkade get duplik8s --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/duplik8s
/Users/rgee0/.arkade/bin/duplik8s: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/duplik8s
+ echo

+ ./arkade get duplik8s --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/duplik8s
/Users/rgee0/.arkade/bin/duplik8s: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/duplik8s
+ echo

+ ./arkade get duplik8s --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/duplik8s
/Users/rgee0/.arkade/bin/duplik8s: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=y3Leo-OfMJcO-ikPC46I/KjPZv73j3bxEn4yI3kvl/CJJPnaOsiP5Nti1Md1Zd/dN8xw9AgFLsJyxeTGKet, stripped
+ rm /Users/rgee0/.arkade/bin/duplik8s
+ echo

+ ./arkade get duplik8s --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/duplik8s
/Users/rgee0/.arkade/bin/duplik8s: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=OwaYoEzMgemddHpU5Ksz/h7EYBrrJ3-LDdfCV_V5s/8FJSDwwvOussNlZt8tgF/5Hk3YgeI_7k1PG1klMF2, stripped
+ rm /Users/rgee0/.arkade/bin/duplik8s
+ echo

+ ./arkade get duplik8s --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/duplik8s.exe
/Users/rgee0/.arkade/bin/duplik8s.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/duplik8s.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis
Copy link
Owner

@rgee0 do you mind rebasing this for merge?

@rgee0
Copy link
Contributor Author

rgee0 commented Oct 25, 2024

Will do. AFK for much of the day

Signed-off-by: Richard Gee <richard@technologee.co.uk>
@rgee0
Copy link
Contributor Author

rgee0 commented Oct 26, 2024

Rebased

@alexellis alexellis merged commit 2350f09 into alexellis:master Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants