Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error in case of an unknown app to install command #529

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

YuviGold
Copy link
Contributor

@YuviGold YuviGold commented Oct 3, 2021

Description

Return an error in case of an unknown app given to install command.
Exit with an error and appropriate message.
The SilenceUsage was turned on so the error message would be clear, just like get command.
In case the user wants to see the help message, he can ask for it explicitly.

Motivation and Context

How Has This Been Tested?

➜  arkade git:(install-unknown-app) ./arkade install kind
Error: cannot install app: kind
➜  arkade git:(install-unknown-app) echo $?
1

Are you a GitHub Sponsor (Yes/No?)

  • Yes
  • No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

Exit with an error and appropriate message.
The `SilenceUsage` was turned on so the error message would be clear, just like `get` command.
In case the user wants to see the help message, he can ask for it explicitly.

Signed-off-by: Yuval Goldberg <yuvigoldi@gmail.com>
@derek derek bot added the new-contributor label Oct 3, 2021
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 769e42e into alexellis:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants