Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jq executable name for release 1.7 #972

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Sep 10, 2023

Description

jq 1.7 has been released. This PR fixes the executable name for the new release.

Motivation and Context

jq maintainers changed the executable names to support various CPU architectures.
Previously something like jq-linux64 but now jq-linux-amd64 and jq-linux-arm64.
They temporarily added the executable with old names to fix for the latest URLs (jqlang/jq#2877).
But they might not retain the executable with the old names.

How Has This Been Tested?

Following commands passed.

go test ./...
go build && ./hack/test-tool.sh jq

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: itchyny <itchyny@cybozu.co.jp>
@@ -104,27 +104,47 @@ func MakeTools() Tools {
Repo: "jq",
Name: "jq",
Description: "jq is a lightweight and flexible command-line JSON processor",
BinaryTemplate: `{{$arch := "arm"}}
BinaryTemplate: `
{{- if or (eq .Version "jq-1.6") (eq .Version "jq-1.5") -}}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. What's the reason you indented it so much?

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 60b4162 into alexellis:master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants