Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update openfaas-loki to use new OCI repository #979

Merged

Conversation

LucasRoesler
Copy link
Contributor

Description

Update the install configuration and process for openfaas-loki so that it uses the OCI repository hosted by Github

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Tested locally with kind

$ kind create cluster
$ arkade install openfaas-loki
$ helm list 
NAME            NAMESPACE       REVISION        UPDATED                                     STATUS          CHART                   APP VERSION
openfaas-loki   default         2               2023-09-30 19:01:45.753063527 +0200 CEST    deployed        openfaas-loki-1.7.3     v1.7.3 

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Update the install configuration and process for openfaas-loki so that
it uses the OCI repository hosted by Github

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit b3aa513 into alexellis:master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants