fix for #311 #315
Merged
fix for #311 #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/commands/voice.js
Outdated
| @@ -61,7 +61,10 @@ module.exports = { | |||
| await DiscordMessages.sendVoiceMessage(interaction, | |||
| client.intlGet(interaction.guildId, 'commandsVoiceBotJoinedVoice')); | |||
| client.log(client.intlGet(null, 'infoCap'), client.intlGet(interaction.guildId, 'commandsVoiceJoin', | |||
| { name: voiceChannel.name, id: voiceChannel.id, guild: voiceChannel.guild.name })); | |||
| { name: voiceChannel.name ? voiceChannel.name : client.intlGet(interaction.guildId, 'unknownVoiceChannelId'), | |||
There was a problem hiding this comment.
I dont think this will work either, this will give error when it tries to access the .name property during the condition. better to do the condition like this:
name: voiceChannel && voiceChannel.name ? voiceChannel.name : client.intl.....
There was a problem hiding this comment.
just changed it, thought it would fail if no name/id/guild is given and send the unknown phrase
|
Also perhaps just use the unknown phrase if the fail. The ones you added dont work well with the "commandsVoiceJoin" phrase. |
|
@alexemanuelol changed everything you wanted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #311