Add support for diagonal Kronecker factors in Kron matrix class
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleximmer
reviewed
Aug 16, 2023
| else: | ||
| # Diagonal Kronecker factor. | ||
| l = Hi | ||
| # This might be too memory intensive since len(Hi) can be large. |
There was a problem hiding this comment.
Remove this comment that is from sorting previously?
There was a problem hiding this comment.
No it is due to the torch.eye, since the Kronecker factor is diagonal it might be too large to explicitly build a len(H_i) x len(H_i) matrix.
|
Thanks! The initialisation is now not using tensors but just float scalars, so |
|
If it passes the tests, I guess we have to find out later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support diagonal Kronecker factors in this library we have to adopt the methods of the
Kronmatrix class to be able to handle this correctly.