Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Contributing" to the README #198

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Add "Contributing" to the README #198

merged 2 commits into from
Jun 15, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Jun 14, 2024

Closes #196

@runame please double check.

@wiseodd wiseodd added the documentation Improvements or additions to documentation label Jun 14, 2024
@wiseodd wiseodd added this to the 0.2 milestone Jun 14, 2024
@wiseodd wiseodd requested a review from runame June 14, 2024 18:10
@wiseodd wiseodd self-assigned this Jun 14, 2024
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated

Pull requests are very welcome. Please follow these guidelines:

1. Use [ruff](https://github.com/astral-sh/ruff) as autoformatter. Please refer to the following [makefile](https://github.com/aleximmer/Laplace/blob/main/makefile) and run it via `make ruff`. Please note that the order of `ruff check --fix` and `ruff format` is important!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add something like

  1. Install via pip install -e .[dev] which will install ruff and all requirements necessary to run the tests and build the docs.

@wiseodd wiseodd merged commit d2d5155 into main Jun 15, 2024
3 checks passed
@wiseodd wiseodd deleted the contributing branch June 15, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Contributing" section to README
2 participants