Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low rank LA #65

Merged
merged 13 commits into from
Dec 10, 2021
Merged

Low rank LA #65

merged 13 commits into from
Dec 10, 2021

Conversation

aleximmer
Copy link
Owner

@aleximmer aleximmer commented Dec 10, 2021 •
edited
Loading

Adds low-rank LA and true diagonal Hessian backend using ASDL.

@runame runame added the enhancement New feature or request label Dec 10, 2021
@runame runame added this to the NeurIPS Prerelease milestone Dec 10, 2021
runame
runame reviewed Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my one minor comment everything looks good now.

laplace/baselaplace.py Outdated Show resolved Hide resolved
@aleximmer aleximmer merged commit 0915472 into main Dec 10, 2021
@aleximmer aleximmer deleted the low-rank branch December 10, 2021 13:58
@aleximmer aleximmer restored the low-rank branch December 10, 2021 15:30
@aleximmer aleximmer deleted the low-rank branch December 10, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
New Year Prerelease
Development

Successfully merging this pull request may close these issues.
2 participants
@aleximmer @runame