Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Added support for oauth2 config #267

Merged
merged 6 commits into from
Sep 24, 2020
Merged

Conversation

mcalster
Copy link
Contributor

@mcalster mcalster commented Sep 16, 2020

Proposed Changes

Fixes #266

Acceptance Test Output

$ make testacc TESTS=TestAccConnectionOAuth2
==> Checking that code complies with gofmt requirements...
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccConnectionOAuth2
--- PASS: TestAccConnectionOAuth2 (2.87s)
PASS
coverage: 12.5% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     3.258s  coverage: 12.5% of statements
?       github.com/alexkappa/terraform-provider-auth0/auth0/internal/debug     [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/random    0.333s                                                                                                     coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0/internal/validation                                                                                                           0.105s   coverage: 0.0% of statements [no tests to run]
?       github.com/alexkappa/terraform-provider-auth0/version   [no test files]

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@mcalster
Copy link
Contributor Author

mcalster commented Sep 16, 2020

This is blocked blocked by go-auth0/auth0#141

@mcalster
Copy link
Contributor Author

@alexkappa I think this getting close to done. Can you have a look?

@mcalster mcalster changed the title Added test for oauth2 config Added support for oauth2 config Sep 21, 2020
@mcalster
Copy link
Contributor Author

@alexkappa this should now also be ready :-)

@alexkappa
Copy link
Owner

Hi @mcalster, I've tagged your changes in go-auth0 to v0.4.6. If we update go.mod we are good to merge this ;)

@mcalster
Copy link
Contributor Author

Awesome 👍 @alexkappa I've updated the version and updated the test results.

@mcalster
Copy link
Contributor Author

Awesome 👍 @alexkappa I've updated the version and updated the test results.

Hi @mcalster, I've tagged your changes in go-auth0 to v0.4.6. If we update go.mod we are good to merge this ;)

When do you think you can get it merged? I'd like to use it this week if possible! 🥇

@alexkappa alexkappa merged commit 2ac44d6 into alexkappa:master Sep 24, 2020
@alexkappa
Copy link
Owner

@mcalster released a new version which includes your changes, many thanks!

@mcalster
Copy link
Contributor Author

mcalster commented Sep 24, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported connection strategy oauth2
2 participants